EMX ead* functions aborts with corrupted EAS

[Yuri Dario]

Calling _ead_read() on a file with corrupted EAS will crash the running program.

Debug shows that in src\lib\io\eadread.c the function:

static int _ead_make_gea (struct _ead_data *ead, PDENA2 pdena, void *arg)

is calling abort() for wrong name:

  if (pdena->szName[pdena->cbName] != 0)
    abort ();

Suggested fix is to return EINVAL or similar:

  if (pdena->szName[pdena->cbName] != 0)
    {
          errno = EINVAL;
          return -1;
    }

memory is freed by caller.

I cannot test the fix right now, but seems good to me.

[bird]

Need a testcase and/or good explanation what's going wrong here.

[Yuri Dario]

Background: ead_* functions are used in Star backup code to deal with extended attributes (and emulate some xattr code).

In its earlier days, Samba/2 used to write bad EAS in certain conditions, so backup of such files was triggering the above abort() call.

Cleaning EAs for broken files fixed the problem on my side, but I think it is not a good idea to abort a program.