Ticket #24 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

libc: fts crashes because it's still using chdir()

Reported by: bird Owned by: bird
Priority: normal Milestone: libc-0.6.1
Component: libc-frontend Version: 0.6
Severity: normal Keywords: libc fts fchdir opendir
Cc:

Description

The various fts APIs when enumerating directories because HAVE_FCHDIR isn't defined and it will end up using chdir() on directory file handles.

Change History

comment:1 Changed 7 years ago by bird

  • Keywords opendir added
  • Status changed from new to assigned

There is more to this than chdir(), the dirfd() macro is not returning any valid filehandle yet because of ticket #14 (http://svn.netlabs.org/libc/ticket/14) which deals with reimplementing opendir() and friends. So, the correct solution here is to restore the solution with keeping that path around. too bad :/

comment:2 Changed 7 years ago by bird

It turned out just to be used in one place, so it's fixed by adding a HAVE_DIRFD. However I put back all the HAVE_FCHDIR stuff for when we do simpler backends which doesn't implement fchdir.

comment:3 Changed 7 years ago by bird

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed in changeset [2497].

comment:4 Changed 7 years ago by bird

  • Version set to 0.6
Note: See TracTickets for help on using tickets.