Ticket #46 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

ilink map file name is wrong when multiple dots are in target name

Reported by: ydario Owned by: bird
Priority: normal Milestone: libc-0.6.1
Component: emx Version: 0.6
Severity: normal Keywords:
Cc:

Description

When the target name has multiple dots (e.g. my.code.dll), ilink will generate a map file without proper extension (e.g. my.code). Patch will force .map extension if map file name is not specified on command line.

Index: emxomfld.c
===================================================================
--- emxomfld.c	(revision 2508)
+++ emxomfld.c	(working copy)
@@ -1659,6 +1659,9 @@
     {
       t = xstrdup (output_fname);
       _remext (t);
+      //yd if module name has multiple dots, ilink will not add .map extension
+      //so I'll force it here
+      strcat( t, ".map");
       map_fname = t;
     }

Change History

comment:1 Changed 7 years ago by bird

  • Status changed from new to closed
  • Resolution set to fixed

if the filename was wihtout an extension the strcat may cause a heapoverrun. Applied with that fixed.

Note: See TracTickets for help on using tickets.