Ticket #58 (closed defect: fixed)

Opened 8 months ago

Last modified 7 months ago

ndpsmb.dll does not distinguish between printer and directory shares

Reported by: herwigb Owned by:
Priority: critical Milestone:
Component: Client Version:
Keywords: ndpsmb printer share Cc:
Blocking: Blocked By:

Description

The Samba Client ndpsmb.dll does not distinguish between printer and directory shares.

The result of this that both eVFSGUI (eCS Bugtracker #1996) and NetDrive? happily mount printers as directories.

The problem is even documented in ndpsmb.c in line 860 and following, where the Samba ressource type is explicitly ignored.

Change History

Changed 7 months ago by ydario

(changeset:128) Instead of default type, we force dev_type to be IPC or A:, so connection to printers fails with rc=7. The error is reported back as ACCESS_DENIED.

This is detected only at connection time, not at mount time.

Changed 7 months ago by ydario

  • status changed from new to closed
  • resolution set to fixed

(changeset:129) the printers are stripped in server shares enumeration.

(changeset:130) now return error code has more sense.

(changeset:131) check for resources also at mount time: to avoid slowing ndctl startup, the check is done only if current thread is not the main thread(1). Mounting a wrong share from nd/ndpm is checked immediately, so next drop of control panel gui will allow users to edit parameters in dialog and try again.

Note: See TracTickets for help on using tickets.